Reviews by M. Conrad

cpanratings
 

RSS

DateTime-Format-Flexible (0.25) ****

A previous review mentions this module missing a parse_datetime method, but the current version has the method.

In fact, this module now implements the DateTime::Format API better than DateTime::Format::Natural! (in the sense that parse_datetime croaks like you would expect, instead of returning a bogus datetime object)

I'm docking one star for speed, though. DateTime::Format::Natural is about 5x faster (which doesn't matter for me, but could for someone with a lot of dates to parse)

M. Conrad - 2013-04-19T12:04:28 (permalink)

2 out of 2 found this review helpful. Was this review helpful to you?  Yes No

DateTime-Format-Natural (1.01) ****

Great module, but it breaks the API of DateTime::Format!

I think this code sums it up:

$date= $self->date_parser->parse_datetime($date);

# WHY!? WHY... *sigh*

if ($self->date_parser->isa('DateTime::Format::Natural')) {

croak "Invalid date: $date"

unless $self->date_parser->success;

}

In other words, you have to special case it if you want a design with pluggable date parsers.

This bug is mentioned right in the documentation, so I get the idea there is no intent to fix it.

M. Conrad - 2013-04-19T11:09:49 (permalink)

1 out of 1 found this review helpful. Was this review helpful to you?  Yes No