Reviews by Guido Flohr

cpanratings
 

RSS

Locale-Country-Multilingual (0.23) ****

This module really fills an annoying gap, and therefore 4 stars. It's also well documented and easy to use. But ...

Data files in a Perl distribution always make me frown. Why do you parse a file LL.dat from a Perl module? Turn them into Perl modules themselves, and let the Perl interpreter do the job. It can do it a lot better, faster, and additionally - with a nice, perlish interface - your users would have it a lot easier to extend your module.

Why do you read "INCDIR/Locale/Country/Multilingual/LL.dat" yourself, but not simply "require Locale::Counry::Multilingual::LL". That has several big advantages (apart from being faster and perlisher):

- People can add more languages by simply placing a language module somewhere in @INC. Currently they have to place that in a directory, where they maybe don't have write access.

- People can override translations for a particular language.

- With a minor internal change it is also possible to override one particular translation. I would actually turn all the data into subroutines. The translation for country "cn" in language "bg" would then be retrieved by a call to Locale::Country::Multilingual::bg::cn(), and if you want to override that, you just override that particular method.

With that change, you can also elegantly solve the problem with country-specific translations. The module Locale::Country::Multilingual::ll_CC would simply have to inherit from Locale::Country::Multilingual::ll, and override only those few methods, where it is needed, instead of redefining the entire data.

An internal change like that described above would then suggest an alternative API: You could turn the module into a mere factory class for the translator objects. These translator objects all inherit from a base class that handles the nasty I/O aspects (utf-8 flag ...), and the users would invoke the methods like CA(), GB(), and so on themselves.

Implementation that falls back to a default language? No problem. Define an additional import flag, where you can define base language(s). In presence of this flags, the translator objects created by the factory simply inherit from the translator for that language (by fiddling with @INC, no problem), and voilà! you get a translator that gives you a country name for country CC in the selected language, or falls back to some default language.

The only thing that becomes tricky is to get a list of the countries that a particular translator knows translations for, but even that is feasible and not an important feature anyway.

Apart from that, never mind, a good module.

Guido Flohr - 2009-06-29T07:52:56 (permalink)

1 out of 2 found this review helpful. Was this review helpful to you?  Yes No

IWL (0.61)

I think the criticism by BKB on IWL, especially on IWL::Text is pretty weak. IWL is a widget library for HTML, and as such pretty sophisticated. IWL::Text encapsulates plain text inside HTML, just as many other modules encapsulate HTML elements, and this is required by the OO approach of IWL.

IWL::String vs. URI::Escape? Why should IWL drag in URI including all dependencies, just for a pretty trivial function?

IMHO it is pretty unfair to slate a piece of software by looking at one single aspect of it. A 1/5 rating from somebody that did not even bother to mention the overall concept of the library with one single word should not be taken too seriously.

Guido Flohr - 2009-05-26T11:09:26 (permalink)

5 out of 5 found this review helpful. Was this review helpful to you?  Yes No

DP-Perl (0.101) *

# Copyright (C) 2003, Guido Flohr, all rights reserved, patents
# pending.

package GF::Perl;

sub concat
{

join '', @_;
}

1;
__END__

When will there be a possibility to kick modules from CPAN that only occupy disk and namespace?

Guido Flohr - 2003-12-12T14:05:21 (permalink)

3 out of 3 found this review helpful. Was this review helpful to you?  Yes No

Crypt-Tea (1.44) *

The author is well-aware, that a similar module Crypt::TEA (uppercase!) already existed on CPAN when he uploaded the module. The similarity isn't the problem, but on case-insensitive or case-preserving file systems, the two modules will conflict. Since this violates a fundamental CPAN law, the overall rating cannot be higher than 1.

The embedded documentation is wrong! It documents functions that are not exported, others are exported but not documented. Furthermore, no license information is given.

As far as the interface is concerned, I cannot see a reason why non-standard asciify-functions should be exported at all.

The test script does not follow the conventions used for CPAN modules.

A custom installer (the file "Install") may be a nice exercise for Perl beginners but is rather a waste of space than a helper. By convention, files named "INSTALL" contain installation information, not an install script.

Apart from that, the module is probably usable, but it violates a lot of unwritten and written conventions for CPAN modules, hence the bad rating.

Proposed enhancements:

1) Rename the module to "Crypt::TEA_PP" (following the general convention in the Crypt:: namespace).

2) Implement the complete interface required by Crypt::CBC (i. e. make it compatible with Crypt::TEA).

3) Implement the additional bells and whistles (TEA in JavaScript, CBC mode etc.) in new functions (encrypt_cbc(), decrypt_cbc(), tea_in _javascript(), ...) and consider an OO approach or at least reduce the amount of exported symbols. @EXPORT_OK is much better suited for typical helper functions.

4) Add the test suite from Crypt::TEA to the module. A standard and exhaustive test suite gives the user a much better feeling with cryptographic modules, because of issues like endianness or integer sizes.

Guido Flohr - 2003-11-27T11:24:43 (permalink)

2 out of 2 found this review helpful. Was this review helpful to you?  Yes No

Crypt-Twofish (2.12) ****

Perfect, except that Crypt::Twofish2 is faster. ;-)

Guido Flohr - 2003-11-27T11:24:20 (permalink)

Was this review helpful to you?  Yes No