Reviews by Benoit Galy

cpanratings
 

RSS

Test-WWW-Mechanize (1.30) *****

Hi,

$mech->html_lint_ok is not very convenient to use with UTF8 : I got mostly
(421:13) Invalid character \xE9 should be written as é

I would recommend either removing this by default in the module code constructor:

# XXX Combine with the cut'n'paste version in get_ok()

my $lint = HTML::Lint->new;

$lint->parse( $self->content );

To
my $lint = HTML::Lint->new( only_types => HTML::Lint::Error::STRUCTURE );

Or either to allow the parameters to be set in $mech->html_lint_ok( \
%params, [$desc] ) and forwarded in HTML::Lint constructor.

Another annoying stuff : not working with Mechanize::GZip...

Benoit Galy - 2010-08-13T09:40:14 (permalink)

0 out of 2 found this review helpful. Was this review helpful to you?  Yes No

Mail-CheckUser (1.21) *

I have been blacklisted because I used this module to check my customer emails (800 emails)

Benoit Galy - 2008-09-15T03:34:15 (permalink)

1 out of 4 found this review helpful. Was this review helpful to you?  Yes No

Catalyst-View-TT (0.26) *

Does not support I18N as META instructions are defined at compile time (and can therefore not used I18N lexicons that are defined at runtime).

Benoit Galy - 2008-04-21T08:31:03 (permalink)

0 out of 4 found this review helpful. Was this review helpful to you?  Yes No

Catalyst-Plugin-I18N (0.07) ****

Hi,

Would be great to include a link to search.cpan.org/~cfranks/HTML-FormFu-... that gives a lot of info on Unicode in Catalyst.

Moreover, a few words on how to handle I18N for YAML files would have been great too. Found rt.cpan.org/Ticket/Display.html?id=33166 that is interesting too.

Benoit Galy - 2008-04-11T07:41:22 (permalink)

2 out of 3 found this review helpful. Was this review helpful to you?  Yes No

Business-Tax-VAT-Validation (0.15) *

Hi,

Module is great, but this version in not correct:

You included spaces in your patterns :
Old version :GB => '([0-9]{9}|[0-9]{12}|GD[0-9]{3}|HA[0-9]{3})',

is now
GB => '([0-9]{3} [0-9]{4} [0-9]{2}( [0-9]{3})?|GD[0-9]{3}|HA[0-9]{3})'

This break existing code as previous versions implied to remove white spaces. And now you make them mandatory (and users do not respect spaces patterns when entering there vat number). It should either be reverted back, or at list make the 'spaces' check optionnal.

This appart, thanks for this great module.

Benoit Galy - 2006-10-02T02:38:49 (permalink)

2 out of 3 found this review helpful. Was this review helpful to you?  Yes No