RSS | Module Info | Add a review of Time-Local

Time-Local (1.1901)

Wait for Time::y2038 to be more stable, then use that. Time::Local is fine, but it has too many special cases for interpreting data.

Ricardo SIGNES - 2009-02-18 21:04:30
Was this review helpful to you?  Yes No

Time-Local (1.1901)

I don't like this module simply because it makes some bold assumption and some stupid requirements which makes it ill suited for many use cases -- and there are no easy ways to disable the assumptions or stupid requirements.

It simply requires there be a "day", an argument list that only specifies Hours, Minutes and Seconds will not work with this module. This makes it often a bad choice of glue, as you can not expect it to fit in-between something that outputs a ts struct and DateTime. (Such as POSIX::strftime).

This module assumes undef is 0: a year of undef, will return an epoch that represents the lowest year in the current century. So set a year to undef, and get same amount of ticks as if you set the year to 2000. It is literally adding information where it wasn't previously and it doesn't warn you. I've got a test on rt for this.

The author has stated an intent to deprecate in favor of Time::y2038
21:10 <@autarch> I'd like to deprecate it, but apparently Time::y2038 isn't stable enough yet

And, as for the guy who gave it 5 stars: (Dear rjbs, no offense to you, my goal is simply to discredit your archaic review, and not to discredit you, or attack you personally -- I still <3 you like a father and want to bear your babies -- accept my apology love..)
<@rjbs> Everybody know Time::Local sucks.
<@rjbs> Time::y2038 has the same API, except without the nonsense.

This might still work for simply perl gmtime and localtime -- use it for *nothing* else though.

logs from irc.perl.org/#moose feb 16, 2009

Evan Carroll - 2009-02-16 19:20:35
Was this review helpful to you?  Yes No

Time-Local (1.13)

It seems to me that the author of previous rating did not understand the purpose of the module (being just the inverse of perl's localtime() function) and how to use it (like localtime, timelocal uses 0..11 as month range).

Slaven Rezic - 2006-12-05 01:25:36
Was this review helpful to you?  Yes No

Time-Local (1.13)

The package assumes that the month October is 30 days long. Moreover, it stops to execute when a non-assumed date occures.
The usage is difficult: you have to parse the date. I think, one should use David Muir Sharnoff's time packages http://search.cpan.org/dist/Time-modules/ instead.

Rev Tamas - 2006-12-01 05:58:51
Was this review helpful to you?  Yes No

Perl.org sites : bugs | dev | history | jobs | learn | lists | use © Copyright 2002-2010 The Perl Foundation Site Information and Contacts root: (Vh | Vc)