RSS | Module Info | Add a review of Perl-Critic

Perl-Critic (1.082)

One of the best utility tools I have seen for any language. It has changed our life and now our code is lot more maintainable, bug free etc etc. Waiting for more and more policies to come through.

Parvesh Garg - 2008-04-22 22:10:16
Was this review helpful to you?  Yes No

Perl-Critic (1.078)

Most of the so-called "best practices" are the personal preferences of one author. This should not have put in such a prominent namespace.

However, if all rules would be moved to another distribution, e.g. "Perl::Critic::Rulesets::Damian_Conway", and this module would only contain the code, I'd rate it a five.

Michael Jacob - 2007-11-08 10:24:01
Was this review helpful to you?  Yes No

Perl-Critic (1.071)

I'm spefically reviewing the documentation and utilities for becoming a Policy developer.

The documentation is clear and concise, and gets a budding Policy writer up to speed in short order.

Further, the testing utilities make adding additional test cases for policies under development are really cool too - the format of the /run tests takes a little getting used to - but once that's under your belt, the tests flow off your fingers faster than you could've manually only updated your test plan.

Kent Cowgill - 2007-08-30 22:25:30
Was this review helpful to you?  Yes No

Perl-Critic (1.051)

What a great tool! Not only was I able to tweak its settings to get it to help me write code the way *I* wanted to write it, but then it was really easy to write my own plugins to test for things that configuration alone could get me.

Using Perl::Critic to enforce (or at least audit) your organization's coding guidelines is a great idea, and it's pretty darn good for personal use, too.

Ricardo SIGNES - 2007-05-08 19:00:44
Was this review helpful to you?  Yes No

Perl-Critic (1.02)

This goes out to all modules like Test::Warnings, Test::Strict, Test::Spelling, etc, but is focused at Perl::Critic directly. These tools are invaluable to me as a perl developer. I tell them how I expect myself and others to code in my dists, and Perl::Critic keeps me honest about those things. Sometimes I'm just lazy. Sometimes I just forget. Perl::Critic is neither.

Bravo. Great job. P::C+++++++++++

Christopher H. Laco - 2007-02-12 09:45:17
Was this review helpful to you?  Yes No

Perl-Critic (1.01)

IMO, the most important module released lately.The author is as nice as the module.

my 003_perl_critic.t looks like this:

# perl_critic test

use strict ;
use warnings ;
use Term::ANSIColor qw(:constants) ;

use Test::Perl::Critic
-severity => 1,
-format => "[%s] %m at " . BOLD . BLUE . "%F:%l" . RESET . ". %e\n",
-exclude =>
[
'Miscellanea::RequireRcsKeywords',
...
],

-profile => 't/perlcriticrc' ;

my $alarm_reached = 0 ;
eval
{
local $SIG{ALRM} = sub {$alarm_reached++ ; die} ;
alarm 1 ;

eval
{
my $input = <STDIN> ;
} ;

alarm 0 ;
} ;

alarm 0 ;

if($alarm_reached)
{
eval <<EOE ;
{
use Test::More qw(no_plan) ;
SKIP:
{
skip("perl critics (press key to run)", 1) if($alarm_reached) ;
}
}
EOE
}
else
{
all_critic_ok() ;
}

which allows me to choose when i want to run Perl::Critic on my code.

nadim khemir NKH - 2007-01-26 15:10:58
Was this review helpful to you?  Yes No

Perl-Critic (0.21)

Perl::Critic analyzes perl code and offers suggestions how best to conform to your/PBP's policies. It simply worked as advertised, and it was easy enough to add my own policies.

The only quibbles I have with it are the numerous dependencies required to install, and the fact that you also have to read up on PPI documentation to write policies.

This is a near-perfect module.

Dan Harbin - 2006-11-30 11:43:22
Was this review helpful to you?  Yes No

Perl-Critic (0.08_02)

Perl-Critic is a source code analyzer that judges your code by the standards set by Damian Conway's book "Perl Best Practices". I tried it on one of my modules (via perlcritic `find lib -name '*.pm'`) and found all of the advice to be good with one exception (already reported to rt.cpan.org).

My one main complaint:
* There should be a little more explanation for the criticisms. Granted, the module does state page numbers for Damian's book, but some of the criticisms forced me to look at the code to understand why it was complaining (e.g. the noisy quoted string complaint). Perhaps a verbose mode to describe the criticism more deeply, or a DIAGNOSTICS section in the POD to detail all of the warnings

I encourage someone to write Test::Perl::Critic or perhaps to add a Module::Build perlcritic action!

Chris Dolan - 2005-09-29 18:48:54
Was this review helpful to you?  Yes No

Perl-Critic (0.07)

A nice module, easy to use and good documented. After configure your own ~/.perlcriticrc it is a great help to find common mistakes or ugly code quick.

Boris Zentner - 2005-09-24 04:23:27
Was this review helpful to you?  Yes No

Perl.org sites : bugs | dev | history | jobs | learn | lists | use © Copyright 2002-2008 The Perl Foundation Site Information and Contacts