RSS | Module Info | Add a review of Hash-Merge-Simple

Hash-Merge-Simple (0.02)

This is a nice way to merge hashes. It has a few advantages over Dan's Hash::Merge. Firstly, it wasn't written by him. Secondly, the code in question has proven itself in thousands of production Catalyst applications. Finally, sometimes ::Simple is the way to do things. I don't want to devote thought to merging hashes, I just want it to happen.

Jonathan Rockway - 2008-05-02 11:20:56
Was this review helpful to you?  Yes No

Hash-Merge-Simple (0.03)

- Already have Hash::Merge that does this and more if you need

- no way to set precedence rules or how to handle value types

- different results that what the standard Hash::Merge users are used to so it can;t be dropped in as a replacement

- "doesn't attempt to combine arrays, objects, scalars, or anything else"
no way to specifcy the behavior you want = more complexity of re-recursively checking your data again.
again, different results than Hash::Merge

- "The code does not currently check for cycles, so infinite loops are possible"
So you have to recursively sanitize the data that you're passing to be recursively merged or else you could bring down the process or even th eentire machine?

Its more "Complex" than "Simple"

---- in Replay to Jonathon's review ---

> This is a nice way to merge hashes. It has a few advantages over Dan's Hash::Merge.
> Firstly, it wasn't written by him.

Really? Seriously? Come on what is your problem? This is very unhelpful. Your reviews are seriously lacking. If I've dome something wrong let me know and I'll fix it, why be a jerk?

FYI, Hash::Merge wasn't written by me either, I just offered to be co maintainer so I could fix a bug and tidy up the code a bit.

> Secondly, the code in question has proven itself in thousands of production Catalyst applications.

*This* is helpful, good job.

> Finally, sometimes ::Simple is the way to do things. I don't want to devote thought to
> merging hashes, I just want it to happen

I tend to agree, however as I pointed out above its not so simple, there's a lot of other things you have to consider or you might end up in trouble.

Dan Muey - 2008-05-01 10:49:50
Was this review helpful to you?  Yes No

Perl.org sites : bugs | dev | history | jobs | learn | lists | use © Copyright 2002-2010 The Perl Foundation Site Information and Contacts root: (Vh | Vc)