RSS | Module Info | Add a review of Config-JSON

6 out of 7 found this review helpful:

Config-JSON (1.0.3) **

This module is a mostly straight forward implementation of a config file object using JSON as the underlying storage mechanism and seems to be written relatively competantly, if a little cargo-cultish (it has a pointless DESTROY method, uses version.pm when it doesn't really need to, and has use warnings in the Makefile.PL)

Unfortunately, it also has Java-style method names instead of Perl-style method names.

But worse, it has COMPULSORY dependencies on things like Test::Perl::Critic that should be optional or author-only.

This will result in a giant dependency chain of modules being installed, just to test something that has no impact at all on the functionality of the module, and appears to cause it to fail to install a lot (judging from CPAN testers).

So I'm docking 1 point for the cargo culting, 1 for the Java method naming and 1 for the dependency explosion (although I want to take 2 for that).

Adam Kennedy - 2007-07-10 16:57:23
Was this review helpful to you?  Yes No


the camel