RSS | Module Info | Add a review of Array-PAT

Array-PAT (1.0.0)

This is a horrible module. Some of the functions only work by coincidence - for instance array_merge() starts with my( @arr1, @arr2 ) = @_; and then attempts to iterate over @arr2. Guess what, there's nothing in @arr2 - because the arrays already got merged in the first line! The rest of the function is a no-op. The fact that the function exists at all demonstrates a severe lack of understanding of very basic concepts in Perl.

This module should be removed from CPAN.

Kent Cowgill - 2007-05-01 09:34:12
Was this review helpful to you?  Yes No

Array-PAT (1.0.0)

This is an outrageously bad module and I implore everyone to have a look at its source code. The shuffle() function takes over half a minute to shuffle a list of 1000 elements. I did some metrics: In order to do the shuffling, it did no less than 8500 full iterations over the input list! in_array() is just plain broken and only works by accident. Again, I recommend a look at the source code for the sake of amusement. Almost all other functions are implemented in an extremely awkward manner at best, suggesting that its author is not familiar with Perl.

Tassilo v. Parseval - 2006-11-01 03:27:18
Was this review helpful to you?  Yes No

Array-PAT (1.0.0)

This useless code should be removed from CPAN. Please. One read will show you that this class can be simply replaced with... well... perl. CORE+List::Utils does everything from this module.

David Alan Pisoni - 2006-10-31 15:12:37
Was this review helpful to you?  Yes No

Perl.org sites : bugs | dev | history | jobs | learn | lists | use © Copyright 2002-2008 The Perl Foundation Site Information and Contacts